Add query to gather counts for types of inline scripts #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
add/script-type-counts-query
branch
from
31ef589
to
0de10ab
Compare
westonruter
force-pushed
the
add/script-type-counts-query
branch
from
0de10ab
to
e39ca99
Compare
westonruter
commented
Aug 4, 2023
Comment on lines
+32
to
+35
| scriptTypes.push( (new Array( script.after_script_size )).fill( 'after' ) ); | ||
| scriptTypes.push( (new Array( script.before_script_size )).fill( 'before' ) ); | ||
| scriptTypes.push( (new Array( script.extra_script_size )).fill( 'extra' ) ); | ||
| scriptTypes.push( (new Array( script.translations_script_size )).fill( 'translations' ) ); |
There was a problem hiding this comment.
Since these metrics are already numbers, it does seem like this should rather be implemented to return a STRUCT and utilize SUM() rather than COUNT() in the query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to determine the relative frequency of the types of inline scripts in
WP_Scripts, namely before, after, extra (wp_localize_script()), and translations.Output for July 2023: