Format metrics; add (min, med, max) for timing metrics #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
...uery-metrics/src/main/java/com/google/cloud/spark/bigquery/v2/customMetrics/MetricUtils.java
Outdated
Show resolved
Hide resolved
...uery-metrics/src/main/java/com/google/cloud/spark/bigquery/v2/customMetrics/MetricUtils.java
Outdated
Show resolved
Hide resolved
...uery-metrics/src/main/java/com/google/cloud/spark/bigquery/v2/customMetrics/MetricUtils.java
Outdated
Show resolved
Hide resolved
...uery-metrics/src/main/java/com/google/cloud/spark/bigquery/v2/customMetrics/MetricsType.java
Outdated
Show resolved
Hide resolved
...uery-metrics/src/main/java/com/google/cloud/spark/bigquery/v2/customMetrics/MetricUtils.java
Outdated
Show resolved
Hide resolved
...ava/com/google/cloud/spark/bigquery/v2/customMetrics/SparkBigQueryCustomMetricConstants.java
Show resolved
Hide resolved
...main/java/com/google/cloud/spark/bigquery/v2/customMetrics/SparkBigQueryParseTimeMetric.java
Outdated
Show resolved
Hide resolved
davidrabinowitz
requested changes
Sep 1, 2023
...t/java/com/google/cloud/spark/bigquery/v2/customMetrics/SparkBigQueryScanTimeMetricTest.java
Outdated
Show resolved
Hide resolved
...ava/com/google/cloud/spark/bigquery/v2/customMetrics/SparkBigQueryTimeInSparkMetricTest.java
Outdated
Show resolved
Hide resolved
vishalkarve15
force-pushed
the
formatMetrics
branch
from
cd8a601
to
a14a8df
Compare
|
/gcbrun |
davidrabinowitz
approved these changes
Sep 5, 2023
vishalkarve15
merged commit 296f1b9
into
GoogleCloudDataproc:master
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows up like this now:
