perf: Using an iterator instead of going through all the data #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @giomerlin for this PR! This task was on my to-do list for 0.15... Can you please revert the changes to build.sbt? |
|
/gcbrun |
|
@davidrabinowitz I didn't realize I pushed the sbt changes, I've just reverted them |
davidrabinowitz
requested changes
Apr 7, 2020
connector/src/main/scala/com/google/cloud/spark/bigquery/direct/BigQueryRDD.scala
Outdated
Show resolved
Hide resolved
|
Have you made changes to |
|
@davidrabinowitz I just pushed the changes to the test, forgot to run the test after I made the scope change to the fetchResponses method, It should run now |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidrabinowitz Comparing the version 0.9.2-beta with the current one I realized that it was pretty slow when doing limit or show operations. It was due the introduction of the ReadRowsHelper in the version 0.10.0-beta which was iterating over all the results before returning the final iterator, so I wrapped the results in a new iterator, achieving the same retry functionality