Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default read format to Arrow #180

Merged
merged 20 commits into from
Jun 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ object SparkBigQueryOptions {
val ReadDataFormatOption = "readDataFormat"
val ViewsEnabledOption = "viewsEnabled"

val DefaultReadDataFormat: DataFormat = DataFormat.AVRO
val DefaultReadDataFormat: DataFormat = DataFormat.ARROW
val DefaultFormat: String = "parquet"
val DefaultIntermediateFormat: IntermediateFormat =
IntermediateFormat(DefaultFormat, FormatOptions.parquet())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class SparkBigQueryOptionsSuite extends FunSuite {
}

test("data format - no value set") {
assertResult("AVRO") {
assertResult("ARROW") {
val options = SparkBigQueryOptions(
parameters,
Map.empty[String, String], // allConf
Expand All @@ -134,10 +134,10 @@ class SparkBigQueryOptionsSuite extends FunSuite {
}
}

test("Set Read Data Format as Arrow") {
assertResult("ARROW") {
test("Set Read Data Format as Avro") {
assertResult("AVRO") {
val options = SparkBigQueryOptions(
parameters + ("readDataFormat" -> "Arrow"),
parameters + ("readDataFormat" -> "Avro"),
Map.empty[String, String], // allConf
new Configuration,
new SQLConf,
Expand Down