Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable useAvroLogicalTypes option in LoadJobConfiguration #276

Conversation

jbergbrede
Copy link
Contributor

In order to be able to load a BigQuery table partitioned on a DATE column using Avro, the option useAvroLogicalTypes has to be activated in LoadJobConfiguration. Otherwise, BigQuery reads DATE columns as INTEGER as documented here: https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-avro#logical_types

@google-cla
Copy link

google-cla bot commented Nov 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jbergbrede
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Nov 17, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jbergbrede
Copy link
Contributor Author

@googlebot I fixed it.

Copy link
Member

@davidrabinowitz davidrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Can you please update connector/src/test/java/com/google/cloud/spark/bigquery/SparkBigQueryConfigTest.java as well?

@jbergbrede
Copy link
Contributor Author

Thanks for the contribution! Can you please update connector/src/test/java/com/google/cloud/spark/bigquery/SparkBigQueryConfigTest.java as well?

Done

Copy link
Member

@davidrabinowitz davidrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice this is Google truth assertThat()

@davidrabinowitz
Copy link
Member

/gcbrun

@davidrabinowitz davidrabinowitz merged commit 67c4a23 into GoogleCloudDataproc:master Nov 19, 2020
@jbergbrede jbergbrede deleted the add-avro-logical-types-option branch November 19, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants