Implementing Datasource v2 writing support #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
anoopj
reviewed
Dec 17, 2020
...tion-test/java/com/google/cloud/spark/bigquery/v2/SparkBigQueryConnectorIntegrationTest.java
Outdated
Show resolved
Hide resolved
anoopj
reviewed
Dec 17, 2020
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/IntermediateRecordWriter.java
Outdated
Show resolved
Hide resolved
connector/src/test/java/com/google/cloud/spark/bigquery/BinaryIteratorsTest.java
Outdated
Show resolved
Hide resolved
connector/src/test/scala/com/google/cloud/spark/bigquery/it/AdHocSuite.scala
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/AvroIntermediateRecordWriter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryDataSourceReader.java
Outdated
Show resolved
Hide resolved
anoopj
reviewed
Dec 17, 2020
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/AvroSchemaConverter.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryDataSourceV2.java
Outdated
Show resolved
Hide resolved
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * Responsible for recursively deleting the intermediate path. Implementing Runnable in order to act |
There was a problem hiding this comment.
Not sure if this is a good idea to run data cleanup as a shutdown hook. Generally shutdown hooks should run quickly and it's entirely possible that the GCS clients and associated thread pools may be in the process of shutting down, so it's hard to guarantee that this cleanup actually happened.
Should we consider alternatives? For instance, can we upload the temporary files with random prefixes and use GCS lifecycle policies to automatically clean them up after a safe window?
There was a problem hiding this comment.
This is done just as a safe-guard in case BigQueryIndirectDataSourceWriter.cleanTemporaryGcsPathIfNeeded has not been called by an error. Relying on GCS object lifecycle will require the bucket to allow lifecycle management, which is not guaranteed.
anoopj
reviewed
Dec 17, 2020
connector/src/main/java/com/google/cloud/spark/bigquery/v2/ParquetIntermediateRecordWriter.java
Outdated
Show resolved
Hide resolved
davidrabinowitz
force-pushed
the
datasource-v2
branch
from
065cd03
to
7cc33d3
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
functicons
requested changes
Jan 14, 2021
...tion-test/java/com/google/cloud/spark/bigquery/v2/SparkBigQueryConnectorIntegrationTest.java
Outdated
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryDataSourceReaderModule.java
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryDataSourceV2.java
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryDataSourceV2.java
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryDataSourceWriterModule.java
Show resolved
Hide resolved
connector/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryDataSourceWriterModule.java
Outdated
Show resolved
Hide resolved
...ector/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryIndirectDataSourceWriter.java
Show resolved
Hide resolved
davidrabinowitz
force-pushed
the
datasource-v2
branch
from
63dc78a
to
737fcdb
Compare
|
/gcbrun |
functicons
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.