Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the option to use parent project for the metadata/jobs API as well #526

Merged

Conversation

davidrabinowitz
Copy link
Member

No description provided.

@davidrabinowitz
Copy link
Member Author

/gcbrun

@codecov-commenter
Copy link

Codecov Report

Merging #526 (875d23b) into master (c1b3f3c) will increase coverage by 0.05%.
The diff coverage is 31.81%.

❗ Current head 875d23b differs from pull request most recent head 40f5cab. Consider uploading reports for the commit 40f5cab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   12.81%   12.87%   +0.05%     
==========================================
  Files          89       89              
  Lines        4416     4419       +3     
  Branches      506      507       +1     
==========================================
+ Hits          566      569       +3     
+ Misses       3798     3797       -1     
- Partials       52       53       +1     
Flag Coverage Δ
integrationtest 12.87% <31.81%> (+0.05%) ⬆️
unittest 12.87% <31.81%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gquery/connector/common/BigQueryClientFactory.java 0.00% <0.00%> (ø)
.../connector/common/BigQueryClientFactoryConfig.java 0.00% <0.00%> (ø)
...spark/bigquery/direct/DirectBigQueryRelation.scala 27.37% <ø> (ø)
...igquery/connector/common/BigQueryClientModule.java 40.00% <50.00%> (ø)
...ogle/cloud/bigquery/connector/common/HttpUtil.java 60.00% <60.00%> (ø)
...ogle/cloud/spark/bigquery/SparkBigQueryConfig.java 62.99% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b3f3c...40f5cab. Read the comment docs.

@VinayLondhe14
Copy link
Member

/gcbrun

@VinayLondhe14
Copy link
Member

Needs mvn spotless:apply

@davidrabinowitz davidrabinowitz merged commit b3afcb2 into GoogleCloudDataproc:master Jan 19, 2022
@davidrabinowitz davidrabinowitz deleted the bq-parent-proj branch January 19, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants