-
Notifications
You must be signed in to change notification settings - Fork 326
Kafka protype. #96
Kafka protype. #96
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
The CLA has been signed as a corporation (Workiva). |
throws IOException { | ||
Gson gson = new Gson(); | ||
String json = gson.toJson(value); | ||
outStream.write(json.getBytes(Charsets.UTF_8)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might consider using versions that write to / read from streams directly ,e.g., https://sites.google.com/site/gson/streaming
(We actually use Jackson in Dataflow core SDK, not sure about pros/cons of Gson).
Hi Kevin, Thanks for this pull request. Some nice stuff in here and others will have a great foundation to build on. I know it's a WIP and that you've moved on. I left some comments, but how you want to respond is up to you. You could make code changes, you could make TODOs, you could leave as-is untouched. The level of polish on a contrib package is generally up to the author. Let me know when it's ready for either more review or merging. Thanks, |
@dhalperi I will probably leave this as is (for now). If you prefer I can put this up on my personal Github rather than here. |
Thanks @kevinsookocheff-wf! I think we'll leave this here and open as a place for others who come looking. |
Hi Kevin, KafkaIO is now in active development under PR #121 for BEAM-52. Would you be okay with closing this PR? |
As requested by #60 (comment)
Contains a prototype implementation of reading from Kafka. Requires Kafka 0.9.0.0.