Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Kafka protype. #96

Conversation

kevinsookocheff-wf
Copy link
Contributor

As requested by #60 (comment)

Contains a prototype implementation of reading from Kafka. Requires Kafka 0.9.0.0.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kevinsookocheff-wf
Copy link
Contributor Author

The CLA has been signed as a corporation (Workiva).

throws IOException {
Gson gson = new Gson();
String json = gson.toJson(value);
outStream.write(json.getBytes(Charsets.UTF_8));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might consider using versions that write to / read from streams directly ,e.g., https://sites.google.com/site/gson/streaming

(We actually use Jackson in Dataflow core SDK, not sure about pros/cons of Gson).

@dhalperi
Copy link
Contributor

Hi Kevin,

Thanks for this pull request. Some nice stuff in here and others will have a great foundation to build on.

I know it's a WIP and that you've moved on. I left some comments, but how you want to respond is up to you. You could make code changes, you could make TODOs, you could leave as-is untouched.

The level of polish on a contrib package is generally up to the author. Let me know when it's ready for either more review or merging.

Thanks,
Dan

@kevinsookocheff-wf
Copy link
Contributor Author

@dhalperi I will probably leave this as is (for now). If you prefer I can put this up on my personal Github rather than here.

@dhalperi
Copy link
Contributor

dhalperi commented Feb 2, 2016

Thanks @kevinsookocheff-wf! I think we'll leave this here and open as a place for others who come looking.

@dhalperi
Copy link
Contributor

Hi Kevin,

KafkaIO is now in active development under PR #121 for BEAM-52. Would you be okay with closing this PR?

@dhalperi dhalperi closed this Mar 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants