Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unit tests to Spanner transaction writer #1538

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -301,4 +301,17 @@ String getTxnTag(PipelineOptions options) {
}
return txnTag;
}

public void setMapper(ObjectMapper mapper) {
this.mapper = mapper;
}

public void setSpannerAccessor(SpannerAccessor spannerAccessor) {
this.spannerAccessor = spannerAccessor;
}

public void setChangeEventSessionConvertor(
ChangeEventSessionConvertor changeEventSessionConvertor) {
this.changeEventSessionConvertor = changeEventSessionConvertor;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,241 @@
/*
* Copyright (C) 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
package com.google.cloud.teleport.v2.templates;

import static org.junit.Assert.assertEquals;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ObjectNode;
import com.google.cloud.spanner.DatabaseClient;
import com.google.cloud.spanner.Mutation;
import com.google.cloud.spanner.Options;
import com.google.cloud.spanner.TransactionContext;
import com.google.cloud.spanner.TransactionRunner;
import com.google.cloud.teleport.v2.spanner.ddl.Ddl;
import com.google.cloud.teleport.v2.spanner.migrations.constants.Constants;
import com.google.cloud.teleport.v2.spanner.migrations.convertors.ChangeEventSessionConvertor;
import com.google.cloud.teleport.v2.spanner.migrations.schema.Schema;
import com.google.cloud.teleport.v2.templates.datastream.DatastreamConstants;
import com.google.cloud.teleport.v2.values.FailsafeElement;
import java.util.Iterator;
import org.apache.beam.runners.dataflow.options.DataflowWorkerHarnessOptions;
import org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor;
import org.apache.beam.sdk.io.gcp.spanner.SpannerConfig;
import org.apache.beam.sdk.options.PipelineOptionsFactory;
import org.apache.beam.sdk.options.ValueProvider;
import org.apache.beam.sdk.transforms.DoFn;
import org.apache.beam.sdk.values.PCollectionView;
import org.junit.Test;
import org.mockito.ArgumentCaptor;

/** Unit tests for SpannerTransactionWriterDoFn class. */
public class SpannerTransactionWriterDoFnTest {
@Test
public void testGetTxnTag() {
String[] args = new String[] {"--jobId=123"};
SpannerConfig spannerConfig = mock(SpannerConfig.class);
DataflowWorkerHarnessOptions options =
PipelineOptionsFactory.fromArgs(args).as(DataflowWorkerHarnessOptions.class);
SpannerTransactionWriterDoFn spannerTransactionWriterDoFn =
new SpannerTransactionWriterDoFn(spannerConfig, null, null, null, "", "mysql", false, true);
String result = spannerTransactionWriterDoFn.getTxnTag(options);
assertEquals(result, "txBy=123");
}

Ddl getTestDdl() {
Ddl ddl =
Ddl.builder()
.createTable("Users")
.column("first_name")
.string()
.max()
.endColumn()
.column("last_name")
.string()
.size(5)
.endColumn()
.column("age")
.int64()
.endColumn()
.primaryKey()
.asc("first_name")
.desc("last_name")
.end()
.endTable()
.createTable("shadow_Users")
.column("first_name")
.string()
.max()
.endColumn()
.column("last_name")
.string()
.size(5)
.endColumn()
.column("version")
.int64()
.endColumn()
.primaryKey()
.asc("first_name")
.desc("last_name")
.end()
.endTable()
.build();
return ddl;
}

@Test
public void testProcessElement() throws Exception {
ObjectMapper mapper = new ObjectMapper();
mapper.enable(DeserializationFeature.USE_BIG_DECIMAL_FOR_FLOATS);
SpannerConfig spannerConfig = mock(SpannerConfig.class);
SpannerAccessor spannerAccessor = mock(SpannerAccessor.class);
PCollectionView<Ddl> ddlView = mock(PCollectionView.class);
Schema schema = mock(Schema.class);
DoFn.ProcessContext processContextMock = mock(DoFn.ProcessContext.class);
DatabaseClient databaseClientMock = mock(DatabaseClient.class);
TransactionRunner transactionCallableMock = mock(TransactionRunner.class);
TransactionContext transactionContext = mock(TransactionContext.class);
ValueProvider<Options.RpcPriority> rpcPriorityValueProviderMock = mock(ValueProvider.class);
ChangeEventSessionConvertor changeEventSessionConvertor =
mock(ChangeEventSessionConvertor.class);

String[] args = new String[] {"--jobId=123"};
DataflowWorkerHarnessOptions options =
PipelineOptionsFactory.fromArgs(args).as(DataflowWorkerHarnessOptions.class);

ObjectNode outputObject = mapper.createObjectNode();
outputObject.put(DatastreamConstants.EVENT_SOURCE_TYPE_KEY, Constants.MYSQL_SOURCE_TYPE);
outputObject.put(DatastreamConstants.EVENT_TABLE_NAME_KEY, "Users");
outputObject.put("first_name", "Johnny");
outputObject.put("last_name", "Depp");
outputObject.put("age", 13);
outputObject.put(DatastreamConstants.MYSQL_TIMESTAMP_KEY, 12345);
FailsafeElement<String, String> failsafeElement =
FailsafeElement.of(outputObject.toString(), outputObject.toString());
Ddl ddl = getTestDdl();

when(processContextMock.element()).thenReturn(failsafeElement);
when(processContextMock.sideInput(any())).thenReturn(ddl);
when(processContextMock.getPipelineOptions()).thenReturn(options);
when(schema.isEmpty()).thenReturn(true);
when(rpcPriorityValueProviderMock.get()).thenReturn(Options.RpcPriority.LOW);
when(spannerConfig.getRpcPriority()).thenReturn(rpcPriorityValueProviderMock);
when(spannerAccessor.getDatabaseClient()).thenReturn(databaseClientMock);
when(changeEventSessionConvertor.transformChangeEventData(eq(outputObject), any(), eq(ddl)))
.thenReturn(outputObject);
when(transactionCallableMock.run(any()))
.thenAnswer(
invocation -> {
TransactionRunner.TransactionCallable<Void> callable = invocation.getArgument(0);
return callable.run(transactionContext);
});
when(databaseClientMock.readWriteTransaction(any(), any())).thenReturn(transactionCallableMock);

SpannerTransactionWriterDoFn spannerTransactionWriterDoFn =
new SpannerTransactionWriterDoFn(
spannerConfig, ddlView, schema, null, "shadow", "mysql", false, true);
spannerTransactionWriterDoFn.setMapper(mapper);
spannerTransactionWriterDoFn.setChangeEventSessionConvertor(changeEventSessionConvertor);
spannerTransactionWriterDoFn.setSpannerAccessor(spannerAccessor);
spannerTransactionWriterDoFn.processElement(processContextMock);
ArgumentCaptor<Iterable<Mutation>> argument = ArgumentCaptor.forClass(Iterable.class);
verify(transactionContext, times(1)).buffer(argument.capture());
Iterable<Mutation> capturedMutations = argument.getValue();
Iterator<Mutation> mutationIterator = capturedMutations.iterator();
Mutation actualDataMutation = null;
Mutation actualShadowTableMutation = null;

if (mutationIterator.hasNext()) {
// Get the first mutation
actualDataMutation = mutationIterator.next();

if (mutationIterator.hasNext()) {
// Get the second mutation
actualShadowTableMutation = mutationIterator.next();
}
}

Mutation.WriteBuilder dataBuilder = Mutation.newInsertOrUpdateBuilder("Users");
dataBuilder.set("first_name").to("Johnny");
dataBuilder.set("last_name").to("Depp");
dataBuilder.set("age").to(13);
Mutation expectedDataMutation = dataBuilder.build();
assertEquals(actualDataMutation, expectedDataMutation);

Mutation.WriteBuilder shadowBuilder = Mutation.newInsertOrUpdateBuilder("shadow_Users");
shadowBuilder.set("first_name").to("Johnny");
shadowBuilder.set("last_name").to("Depp");
shadowBuilder.set("timestamp").to(12345);
shadowBuilder.set("log_file").to("");
shadowBuilder.set("log_position").to(-1);
Mutation expectedShadowMutation = shadowBuilder.build();
assertEquals(actualShadowTableMutation, expectedShadowMutation);

verify(processContextMock, times(1)).output(any(com.google.cloud.Timestamp.class));
shreyakhajanchi marked this conversation as resolved.
Show resolved Hide resolved
}

@Test
public void testProcessElementWithInvalidChangeEvent() throws Exception {
ObjectMapper mapper = new ObjectMapper();
mapper.enable(DeserializationFeature.USE_BIG_DECIMAL_FOR_FLOATS);
SpannerConfig spannerConfig = mock(SpannerConfig.class);
SpannerAccessor spannerAccessor = mock(SpannerAccessor.class);
PCollectionView<Ddl> ddlView = mock(PCollectionView.class);
Schema schema = mock(Schema.class);
DoFn.ProcessContext processContextMock = mock(DoFn.ProcessContext.class);
ChangeEventSessionConvertor changeEventSessionConvertor =
mock(ChangeEventSessionConvertor.class);

ObjectNode outputObject = mapper.createObjectNode();
outputObject.put(DatastreamConstants.EVENT_SOURCE_TYPE_KEY, Constants.MYSQL_SOURCE_TYPE);
outputObject.put(DatastreamConstants.EVENT_TABLE_NAME_KEY, "Users1");
outputObject.put("first_name", "Johnny");
outputObject.put("last_name", "Depp");
outputObject.put("age", 13);
outputObject.put(DatastreamConstants.MYSQL_TIMESTAMP_KEY, 123);
FailsafeElement<String, String> failsafeElement =
FailsafeElement.of(outputObject.toString(), outputObject.toString());
Ddl ddl = getTestDdl();

when(processContextMock.element()).thenReturn(failsafeElement);
when(processContextMock.sideInput(any())).thenReturn(ddl);
when(schema.isEmpty()).thenReturn(true);
when(changeEventSessionConvertor.transformChangeEventData(eq(outputObject), any(), eq(ddl)))
.thenReturn(outputObject);

SpannerTransactionWriterDoFn spannerTransactionWriterDoFn =
new SpannerTransactionWriterDoFn(
spannerConfig, ddlView, schema, null, "shadow", "mysql", false, true);
spannerTransactionWriterDoFn.setMapper(mapper);
spannerTransactionWriterDoFn.setChangeEventSessionConvertor(changeEventSessionConvertor);
spannerTransactionWriterDoFn.setSpannerAccessor(spannerAccessor);
spannerTransactionWriterDoFn.processElement(processContextMock);

ArgumentCaptor<FailsafeElement> argument = ArgumentCaptor.forClass(FailsafeElement.class);
verify(processContextMock, times(1))
.output(eq(SpannerTransactionWriter.PERMANENT_ERROR_TAG), argument.capture());
assertEquals(
"Table from change event does not exist in Spanner. table=Users1",
argument.getValue().getErrorMessage());
}
}