Revise Datastream to BigQuery IT's #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1644 +/- ##
============================================
- Coverage 42.27% 42.26% -0.01%
+ Complexity 3167 3166 -1
============================================
Files 791 791
Lines 46131 46137 +6
Branches 4934 4935 +1
============================================
- Hits 19502 19501 -1
- Misses 25039 25045 +6
- Partials 1590 1591 +1
|
Polber
force-pushed
the
jkinard/datastream-bq
branch
5 times, most recently
from
fb7d28d
to
2d025b3
Compare
Polber
force-pushed
the
jkinard/datastream-bq
branch
7 times, most recently
from
f85ad56
to
1492a6e
Compare
Polber
force-pushed
the
jkinard/datastream-bq
branch
from
1492a6e
to
0534495
Compare
Polber
force-pushed
the
jkinard/datastream-bq
branch
from
0534495
to
6fe0adb
Compare
Polber
force-pushed
the
jkinard/datastream-bq
branch
2 times, most recently
from
8ca570b
to
8682555
Compare
Polber
force-pushed
the
jkinard/datastream-bq
branch
2 times, most recently
from
ccc500a
to
641eb15
Compare
damccorm
reviewed
Jul 11, 2024
| try { | ||
| return resourceManager().getRowCount(tableId().getTable()); | ||
| } catch (Exception e) { | ||
| if (ExceptionUtils.containsMessage(e, "Not found: Table")) { |
There was a problem hiding this comment.
It seems kind of odd to handle this exception at this level, especially since there's only one caller who does conditional logic on top anyways. Could we more cleanly just handle this in check instead?
There was a problem hiding this comment.
Are you saying like this?
There was a problem hiding this comment.
Yeah, I think that is much cleaner - thanks
Polber
force-pushed
the
jkinard/datastream-bq
branch
from
641eb15
to
8d422a5
Compare
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Polber
force-pushed
the
jkinard/datastream-bq
branch
from
8d422a5
to
2507001
Compare
damccorm
approved these changes
Jul 12, 2024
damccorm
added
the
Google LGTM
copybara-service
bot
merged commit 7662362
into
GoogleCloudPlatform:main
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.