Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Beam YAML main.py #1709

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Use Beam YAML main.py #1709

merged 1 commit into from
Jul 16, 2024

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Jul 2, 2024 •
edited
Loading

Also adds caching of yaml providers to Dockerfile as well as hides the yaml_pipeline provider from UI in the @Template tag

@Polber Polber requested a review from damccorm July 2, 2024 14:53
@Polber Polber self-assigned this Jul 2, 2024
@Polber
Copy link
Contributor Author

Polber commented Jul 2, 2024

R: @robertwb

@Polber Polber force-pushed the jkinard/yaml-template-2.57 branch 2 times, most recently from fcc55ec to 73bb404 Compare July 2, 2024 15:11
@Polber Polber force-pushed the jkinard/yaml-template-2.57 branch from 73bb404 to 31f305c Compare July 3, 2024 17:08
@Polber Polber requested a review from robertwb July 3, 2024 17:08
robertwb
robertwb approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to update the description with the other changes as well (e.g. making the yaml argument hidden, caching in the docker build.)

python/src/main/python/yaml-template/main.py Outdated Show resolved Hide resolved
@Polber
Use Beam YAML main.py
af93e43 
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
@Polber Polber force-pushed the jkinard/yaml-template-2.57 branch from 31f305c to af93e43 Compare July 3, 2024 21:52
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.26%. Comparing base (0bcf179) to head (af93e43).
Report is 57 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##               main    #1709    +/-   ##
==========================================
  Coverage     41.25%   41.26%            
+ Complexity     3240     2938   -302     
==========================================
  Files           771      771            
  Lines         45127    45127            
  Branches       4819     4819            
==========================================
+ Hits          18619    18622     +3     
+ Misses        24940    24938     -2     
+ Partials       1568     1567     -1
Components Coverage Δ
spanner-templates 61.27% <ø> (+0.02%) ⬆️
spanner-import-export 64.42% <ø> (+0.06%) ⬆️
spanner-live-forward-migration 74.14% <ø> (ø)
spanner-live-reverse-replication 50.56% <ø> (ø)
spanner-bulk-migration 80.63% <ø> (ø)

see 2 files with indirect coverage changes

@Polber Polber added the Google LGTM Approval of a pull request to be merged into the repository label Jul 9, 2024
@Polber Polber merged commit 580805c into GoogleCloudPlatform:main Jul 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertwb robertwb robertwb approved these changes

@damccorm damccorm Awaiting requested review from damccorm

Assignees

@Polber Polber

Labels
Google LGTM Approval of a pull request to be merged into the repository size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Polber @robertwb