[Cloud Spanner to BigQuery Template] Fix a NPE when one of the source fields contains a NULL value. #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fields contains a NULL value. Without this fix, the template expects all the source record fields to have non-NULL values. If there is one, an exception is thrown: org.apache.beam.sdk.util.UserCodeException:java.lang.NullPointerException: Column field0 contains NULL value. The reason is that SpannerUtils class tries to call struct.getString/getLong/etc. unconditionally, and these methods throw an exception if the value is null. The fix is to skip such fields and not include them in the JSON object (TableRow) being written to BigQuery. This will also allow a target field in BigQuery to not exist at all if the corresponding source field in Spanner is always null.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
============================================
+ Coverage 41.26% 42.27% +1.00%
+ Complexity 3242 3165 -77
============================================
Files 771 791 +20
Lines 45127 46133 +1006
Branches 4819 4935 +116
============================================
+ Hits 18622 19502 +880
- Misses 24938 25039 +101
- Partials 1567 1592 +25
|
Set the default value for the LastName column in the target BQ table, not in the source Spanner table.
AnandInguva
approved these changes
Jul 9, 2024
… of default values.
an2x
added
the
Google LGTM
copybara-service
bot
merged commit ad37e9b
into
GoogleCloudPlatform:main
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, the template expects all the source record fields to have non-NULL values. If there is one, an exception is thrown:
org.apache.beam.sdk.util.UserCodeException:java.lang.NullPointerException: Column field0 contains NULL value.
The reason is that SpannerUtils class tries to call struct.getString/getLong/etc. unconditionally, and these methods throw an exception if the value is null. The fix is to skip such fields and not include them in the JSON object (TableRow) being written to BigQuery. This will also allow a target field in BigQuery to not exist at all if the corresponding source field in Spanner is always null.