Add version option to spark_service. #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Kuster <jasonkuster@google.com>
|
2 comments
|
amitsela
reviewed
Dec 9, 2016
| @@ -203,6 +203,9 @@ def _GetOptionDecoderConstructions(cls): | |||
| 'default': spark_service.PROVIDER_MANAGED, | |||
| 'valid_values': [spark_service.PROVIDER_MANAGED, | |||
| spark_service.PKB_MANAGED]}), | |||
| 'version': (option_decoders.EnumDecoder, { | |||
| 'default': spark_service.SPARK_1_6_2, | |||
There was a problem hiding this comment.
Spark runner upgraded to 1.6.3 - though it really shouldn't matter much, and would be compatible.
There was a problem hiding this comment.
And now I notice that this is a bit more general, and not Beam specific... anyway - 1.6.3 was released.
|
This PR is over a year old and it looks like we lost track of it. Is this still valid? If so, please reply and somebody will review in the next couple of weeks. |
|
I think we can close this. I can't remember why this was necessary and I've been working on other things for a while now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Kuster jasonkuster@google.com
Allows specifying version of Spark to use in managed Spark benchmarks.