Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes yum proxy configuration bug #1598

Merged
merged 7 commits into from Mar 21, 2018
Merged

Fixes yum proxy configuration bug #1598

merged 7 commits into from Mar 21, 2018

Conversation

piotrkpc
Copy link
Contributor

This fixes yum proxy configuration bug. Before this perfkit command:

pkb.py --cloud=OpenStack --run_uri=browbeat --ignore_package_requirements=True --openstack_floating_ip_pool=public --machine_type=p.c2r2 --image=Centos-7 --http_proxy=http://IP.IP.IP.IP:8080 --openstack_image_username=centos --openstack_network=browbeat_private --https_proxy=http://IP.IP.IP.IP:8080 --benchmarks=fio --openstack_volume_size=1 --os_type=rhel --timing_measurements=runtimes

fails with yum error:

Options error: Error parsing "proxy = '\'"http://10.10.10.1:8080";\''": URL must be http, ftp, https, socks4, socks4a, socks5 or socks5h not ""

We don't need quotation marks neither semicolon at the eol in /etc/yum.conf

@jellyfishcake jellyfishcake requested review from klausw and removed request for klausw March 19, 2018 22:38
Copy link
Member

@tohaowu tohaowu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you resolve the code conflict?

@tohaowu tohaowu merged commit b251c8e into GoogleCloudPlatform:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants