Automatically create and delete cluster #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -301,3 +321,8 @@ def Cleanup(benchmark_spec): | |||
| command = ("""echo 'disable "{0}"; drop "{0}"; exit' | """ | |||
There was a problem hiding this comment.
Nit: you could probably skip this if the cluster is being deleted.
| FLAGS.google_bigtable_zone_name, | ||
| FLAGS.google_bigtable_cluster_name) | ||
| logging.info('Found cluster: %s', cluster) | ||
| logging.info('No cluster; will create in Prepare.') |
There was a problem hiding this comment.
Looks like this gets logged even if you found a cluster
hildrum
force-pushed
the
cloud_bigtable
branch
2 times, most recently
from
6bc7236
to
c2138d1
Compare
|
PTAL. |
| @@ -0,0 +1,84 @@ | |||
| # Copyright 2014 PerfKitBenchmarker Authors. All rights reserved. | |||
There was a problem hiding this comment.
This file should probably be called gcp_bigtable, rather than gce.
|
@ehankland @cmccoy PTAL. |
| FLAGS = flags.FLAGS | ||
|
|
||
|
|
||
| class GceBigtableCluster(resource.BaseResource): |
|
Thanks for your comments. Ready for another review. |
|
LGTM |
ustiugov
pushed a commit
to parsa-epfl/PerfKitBenchmarker
that referenced
this pull request
Jun 9, 2016
* Automatically create and delete cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically create and delete a bigtable cluster if none if specified on the command line. This means the benchmark is runnable without any extra flags.
@cmccoy PTAL.