Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setAnnotation for simple-udp to use customized key & value #576

Merged
merged 4 commits into from Feb 12, 2019

Conversation

Yingxin-Jiang
Copy link
Contributor

This is a small fix base on commit ba92be3

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 068cabf2-77bf-4408-9fda-81ab4da5c7e4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@jkowalski
Copy link
Contributor

this needs to be built and pushed to container registry, let me do it, then your test will pass.

@jkowalski
Copy link
Contributor

docker push gcr.io/agones-images/udp-server:0.7 complete

can you sync your tree to the latest version and rebase so this commit is minimal?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4107f2fb-246f-4c90-903e-4a75a8b417dd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/576/head:pr_576 && git checkout pr_576
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-6e6443a

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0da0b51a-d1eb-4c0c-8e11-6eb889f8b189

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/576/head:pr_576 && git checkout pr_576
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-a14b4fd

@markmandel
Copy link
Member

@jkowalski this LGTM - you got any issues, or can we push this through?

@Yingxin-Jiang
Copy link
Contributor Author

@jkowalski - I didn't see commit related to udp-server:0.7 on https://github.com/GoogleCloudPlatform/agones/commits/master. Do I still need to sync to the latest version? or this can be pulled directly?

@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones labels Feb 12, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 12, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 35da74bc-d5af-43af-af80-80f70624bcd0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/576/head:pr_576 && git checkout pr_576
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-ab74d1f

@markmandel markmandel merged commit 30cb07f into googleforgames:master Feb 12, 2019
@Yingxin-Jiang Yingxin-Jiang deleted the fix-set-annotations branch February 12, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants