Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing cluster selector from multi-cluster allocation policies. #733

Merged
merged 2 commits into from Apr 25, 2019

Conversation

pooneh-m
Copy link
Collaborator

@pooneh-m pooneh-m commented Apr 19, 2019

The cluster selector logic is implemented as an iterator on allocation policies.
This is to implement multi-cluster allocation as explained in #597

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 81c214e1-7a8a-475f-9a4b-5b624c219937

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 616ac71e-130b-41f8-b6df-bbba4263b001

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/733/head:pr_733 && git checkout pr_733
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0a8003d

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the comments are about idiomatic Go type things, but otherwise, look good!

(You break down PR's into way smaller chunks than I do 👍 I should learn from you)

@markmandel
Copy link
Member

/cc @broady to tell me if I'm wrong in my opinions of Go naming (which I may be!) 😄

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3027383f-443a-4cc8-9502-fbf9cab1b007

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/733/head:pr_733 && git checkout pr_733
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-26fc672

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bb9e9c67-2587-4229-bd0b-282d034c41b4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/733/head:pr_733 && git checkout pr_733
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-669d0f2

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱 Awesome.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: db430099-26ef-4fae-a525-aa58c348da77

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e3063205-ca6c-4345-9b16-63ad2703acd9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/733/head:pr_733 && git checkout pr_733
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-ae8c072

@markmandel markmandel merged commit fd86d86 into googleforgames:master Apr 25, 2019
@markmandel markmandel added the kind/feature New features for Agones label Apr 27, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants