New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing cluster selector from multi-cluster allocation policies. #733
Conversation
Build Failed 😱 Build Id: 81c214e1-7a8a-475f-9a4b-5b624c219937 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 616ac71e-130b-41f8-b6df-bbba4263b001 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the comments are about idiomatic Go type things, but otherwise, look good!
(You break down PR's into way smaller chunks than I do 👍 I should learn from you)
/cc @broady to tell me if I'm wrong in my opinions of Go naming (which I may be!) 😄 |
Build Succeeded 👏 Build Id: 3027383f-443a-4cc8-9502-fbf9cab1b007 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: bb9e9c67-2587-4229-bd0b-282d034c41b4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐱 Awesome.
Build Failed 😱 Build Id: db430099-26ef-4fae-a525-aa58c348da77 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: e3063205-ca6c-4345-9b16-63ad2703acd9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
The cluster selector logic is implemented as an iterator on allocation policies.
This is to implement multi-cluster allocation as explained in #597