Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use shorter instance uri when logging #213

Merged
merged 1 commit into from
Dec 14, 2022
Merged

feat: use shorter instance uri when logging #213

merged 1 commit into from
Dec 14, 2022

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Dec 13, 2022

Change Description

Uses "project.region.cluster.instance" instead of the full instance URI when logging for a more compact reference.

example:

2022/12/13 23:27:56 [proj.region.clust.inst] client closed the connection
2022/12/13 23:27:56 [proj.region.clust.inst] Listening on 127.0.0.1:5000
2022/12/13 23:27:56 [proj.region.clust.inst1] Listening on 127.0.0.1:6000
2022/12/13 23:27:56 [proj.region.clust.inst2] Listening on 127.0.0.1:6001

Depends on #210

Checklist

  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea.
  • Ensure the tests and linter pass
  • Appropriate documentation is updated (if necessary)

Relevant issues:

@kurtisvg kurtisvg requested a review from a team December 13, 2022 23:30
@kurtisvg kurtisvg requested a review from enocom December 13, 2022 23:31
Base automatically changed from verify_inst to main December 14, 2022 20:55
@kurtisvg kurtisvg enabled auto-merge (squash) December 14, 2022 21:00
@kurtisvg kurtisvg merged commit 87c44db into main Dec 14, 2022
@kurtisvg kurtisvg deleted the short_inst2 branch December 14, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants