Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for public IP connections #566

Merged
merged 1 commit into from
Jan 29, 2024
Merged

feat: add support for public IP connections #566

merged 1 commit into from
Jan 29, 2024

Conversation

jackwotherspoon
Copy link
Contributor

@jackwotherspoon jackwotherspoon commented Jan 19, 2024 •
edited
Loading

Add support for --public-ip flag and public IP query option to allow connections to AlloyDB over public IP.

  • Add support for flag and query params
  • Get current tests to pass
  • Add integration test for public IP
  • Update README with sample

@jackwotherspoon jackwotherspoon self-assigned this Jan 19, 2024
jackwotherspoon
jackwotherspoon commented Jan 19, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
enocom
enocom reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. We just need to make sure query params can override the global option.

@jackwotherspoon jackwotherspoon changed the title WIP: add support for public IP connections feat: add support for public IP connections Jan 22, 2024
@jackwotherspoon jackwotherspoon marked this pull request as ready for review January 22, 2024 18:49
@enocom enocom added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 22, 2024
@enocom enocom removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 29, 2024
@enocom enocom merged commit ac21696 into main Jan 29, 2024
18 checks passed
@enocom enocom deleted the public-ip branch January 29, 2024 20:37
@release-please release-please bot mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@cthumuluru cthumuluru Awaiting requested review from cthumuluru

@nancynh nancynh Awaiting requested review from nancynh

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackwotherspoon @enocom