Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure graceful shutdown on fuse error #638

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: ensure graceful shutdown on fuse error #638

merged 1 commit into from
Apr 25, 2024

Conversation

enocom
Copy link
Member

@enocom enocom commented Apr 25, 2024

If the FUSE mount has not succeeded due to misconfiguration, the Proxy should still shutdown without panicing.

Related to GoogleCloudPlatform/cloud-sql-proxy#2013

Copy link
Collaborator

@nancynh nancynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If the FUSE mount has not succeeded due to misconfiguration, the Proxy
should still shutdown without panicing.

Related to GoogleCloudPlatform/cloud-sql-proxy#2013
@enocom enocom enabled auto-merge (squash) April 25, 2024 22:58
@enocom enocom merged commit eb4435b into main Apr 25, 2024
18 checks passed
@enocom enocom deleted the graceful-close branch April 25, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants