fix: support shorter refresh durations #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
suggested changes
Aug 24, 2022
internal/alloydb/instance.go
Outdated
Comment on lines
221
to
225
| d := certExpiry.Sub(now) | ||
| if d <= time.Hour { | ||
| return 55 * time.Minute | ||
| } | ||
| return time.Until(now.Add(time.Duration(d / 2))) |
There was a problem hiding this comment.
I don't think this is quite what we want to do. If something odd happens and a certificate with a duration of less than 1 hour incurs, this will still wait 55 minutes to refresh that cert.
What we really want the logic to be is in the certExpiry is <= 1hr (although maybe ~65 minutes gives us a better margin of error) then we use a window of 5 minutes.
How about something like this:
// default window is half of the certs expected duration
w := time.Until(certExpiry) / 2
if w < time.Hour {
w = 5 * time.Minute
}
return wThere was a problem hiding this comment.
I've extended the edge case checking.
kurtisvg
approved these changes
Sep 1, 2022
enocom
added a commit
to GoogleCloudPlatform/cloud-sql-go-connector
that referenced
this pull request
Nov 1, 2022
The change here updates the calculation of how long to wait before starting a refresh cycle. This is a port of GoogleCloudPlatform/alloydb-go-connector#103.
enocom
added a commit
to GoogleCloudPlatform/cloud-sql-go-connector
that referenced
this pull request
Nov 2, 2022
The change here updates the calculation of how long to wait before starting a refresh cycle. This is a port of GoogleCloudPlatform/alloydb-go-connector#103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.