chore(ci): add unit tests for 32-bit linux and windows #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
changed the title
kurtisvg
suggested changes
May 17, 2022
internal/alloydb/instance.go
Outdated
| @@ -125,6 +125,9 @@ func (r *refreshOperation) IsValid() bool { | |||
| // required information approximately 5 minutes before the previous certificate | |||
| // expires (every 55 minutes). | |||
| type Instance struct { | |||
| // OpenConns is the number of open connections to the instance. | |||
| OpenConns uint64 | |||
There was a problem hiding this comment.
Can we move this commit into a seperate PR with a "fix:" title?
.github/workflows/tests.yaml
Outdated
Comment on lines
70
to
82
| linux-32bit: | ||
| name: "unit tests (linux/386)" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Setup Go 1.18 | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.18 | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| - name: Run tests | ||
| run: | | ||
| GOARCH=386 go test -v -cover -short ./... |
There was a problem hiding this comment.
I think we can use env for this: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idenv
I think that also means we can combine the linux and windows jobs into a single job with a matrix between the two as well
kurtisvg
approved these changes
May 17, 2022
kurtisvg
approved these changes
May 17, 2022
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Run unit tests on 32-bit Linux and Windows with latest Go version. Need to merge #33 first
fixes: #30