fix: return a friendly error if the dialer is closed #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mvdan in case you'd like to provide any feedback. |
enocom
force-pushed
the
friendly-error
branch
3 times, most recently
from
f2f1623
to
e9d41d3
Compare
mvdan
reviewed
Apr 4, 2024
mvdan
approved these changes
Apr 6, 2024
If the dialer has already been closed, return a clear error. Fixes #522
enocom
added a commit
to GoogleCloudPlatform/cloud-sql-go-connector
that referenced
this pull request
Apr 8, 2024
enocom
added a commit
to GoogleCloudPlatform/cloud-sql-go-connector
that referenced
this pull request
Apr 9, 2024
enocom
added a commit
to GoogleCloudPlatform/cloud-sql-go-connector
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the dialer has already been closed, return a clear error.
Fixes #522