Ensure mcp map configuration is unique #1346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerobfd
suggested changes
Oct 26, 2022
| @@ -33,8 +33,12 @@ install_managed_startup_config() { | |||
| local ASM_OPTS="" | |||
| local MCP_CONFIG | |||
|
|
|||
| declare -A mcp_map | |||
There was a problem hiding this comment.
Using declare/arrays doesn't work in all shells that our customers use, so we've explicitly avoided using them anywhere else in asmcli. There should be a way to do what you want either with string matching or with jq or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: since we append options to the configMap already present on the cluster, we need to make sure that the newer configuration is unique