Do not support channel selection via CLI args #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments.
djazayeri
approved these changes
Aug 29, 2023
wonjekang
pushed a commit
to wonjekang/anthos-service-mesh-packages
that referenced
this pull request
Aug 31, 2023
Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments.
zerobfd
pushed a commit
that referenced
this pull request
Sep 5, 2023
This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner.
sergii-ssh
added a commit
that referenced
this pull request
Sep 5, 2023
* Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
sergii-ssh
added a commit
that referenced
this pull request
Sep 6, 2023
* Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
sergii-ssh
added a commit
that referenced
this pull request
Oct 11, 2023
* Merge main to staging-1.18 (#1494) * Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com> * Bump revision 1.18.4-asm.0 (#1505) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
sergii-ssh
added a commit
that referenced
this pull request
Nov 14, 2023
* Merge main to staging-1.18 (#1494) * Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com> * Bump revision 1.18.4-asm.0 (#1505) * Populate MonitoringConfig values to GCP_METADATA (#1511) (#1512) * Populate MonitoringConfig values to GCP_METADATA (#1511) * Populate MonitoringConfig values to GCP_METADATA (#1498) * Populate MonitoringConfig values to GCP_METADATA * Add quotes to fix build lint error * Add quotes to fix build lint error * Resolve minor problem and code optimization * Add double-quotes for lint * Update lint changes * Update the logic to identify empty monitoring config * Update the logic to identify empty monitoring config * Remove unnecessary empty line * Fix the issue for null value of monitoringConfig (#1525) * Fix the issue for null value of monitoringConfig * Use fleet project ID for monitoringConfig * Organize kpt files even in offline mode (#1532) * Bump revision 1.18.5-asm.2 (#1536) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
sergii-ssh
added a commit
that referenced
this pull request
Dec 12, 2023
* Merge main to staging-1.18 (#1494) * Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com> * Bump revision 1.18.4-asm.0 (#1505) * Populate MonitoringConfig values to GCP_METADATA (#1511) (#1512) * Populate MonitoringConfig values to GCP_METADATA (#1511) * Populate MonitoringConfig values to GCP_METADATA (#1498) * Populate MonitoringConfig values to GCP_METADATA * Add quotes to fix build lint error * Add quotes to fix build lint error * Resolve minor problem and code optimization * Add double-quotes for lint * Update lint changes * Update the logic to identify empty monitoring config * Update the logic to identify empty monitoring config * Remove unnecessary empty line * Fix the issue for null value of monitoringConfig (#1525) * Fix the issue for null value of monitoringConfig * Use fleet project ID for monitoringConfig * Organize kpt files even in offline mode (#1532) * Bump revision 1.18.5-asm.2 (#1536) * Detect old default ingress gateway earlier in installation flow (#1545) * [1.18] bump revision (#1548) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
sergii-ssh
added a commit
that referenced
this pull request
Jan 16, 2024
* Merge main to staging-1.18 (#1494) * Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com> * Bump revision 1.18.4-asm.0 (#1505) * Populate MonitoringConfig values to GCP_METADATA (#1511) (#1512) * Populate MonitoringConfig values to GCP_METADATA (#1511) * Populate MonitoringConfig values to GCP_METADATA (#1498) * Populate MonitoringConfig values to GCP_METADATA * Add quotes to fix build lint error * Add quotes to fix build lint error * Resolve minor problem and code optimization * Add double-quotes for lint * Update lint changes * Update the logic to identify empty monitoring config * Update the logic to identify empty monitoring config * Remove unnecessary empty line * Fix the issue for null value of monitoringConfig (#1525) * Fix the issue for null value of monitoringConfig * Use fleet project ID for monitoringConfig * Organize kpt files even in offline mode (#1532) * Bump revision 1.18.5-asm.2 (#1536) * Detect old default ingress gateway earlier in installation flow (#1545) * [1.18] bump revision (#1548) * Bump revision 1.18.7-asm.0 (#1561) * Bump revision 1.18.7-asm.0 * Disable SC2317 since we use trap --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
sergii-ssh
added a commit
that referenced
this pull request
Feb 9, 2024
* Merge main to staging-1.18 (#1494) * Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com> * Bump revision 1.18.4-asm.0 (#1505) * Populate MonitoringConfig values to GCP_METADATA (#1511) (#1512) * Populate MonitoringConfig values to GCP_METADATA (#1511) * Populate MonitoringConfig values to GCP_METADATA (#1498) * Populate MonitoringConfig values to GCP_METADATA * Add quotes to fix build lint error * Add quotes to fix build lint error * Resolve minor problem and code optimization * Add double-quotes for lint * Update lint changes * Update the logic to identify empty monitoring config * Update the logic to identify empty monitoring config * Remove unnecessary empty line * Fix the issue for null value of monitoringConfig (#1525) * Fix the issue for null value of monitoringConfig * Use fleet project ID for monitoringConfig * Organize kpt files even in offline mode (#1532) * Bump revision 1.18.5-asm.2 (#1536) * Detect old default ingress gateway earlier in installation flow (#1545) * [1.18] bump revision (#1548) * Bump revision 1.18.7-asm.0 (#1561) * Bump revision 1.18.7-asm.0 * Disable SC2317 since we use trap * Bump revision 1.18.7-asm.5 (#1571) * Bump revision 1.18.7-asm.5 * Update google-cloud packages * Update revision 1.18.7-asm.4 (#1581) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
sergii-ssh
added a commit
that referenced
this pull request
Mar 11, 2024
* Merge main to staging-1.18 (#1494) * Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com> * Bump revision 1.18.4-asm.0 (#1505) * Populate MonitoringConfig values to GCP_METADATA (#1511) (#1512) * Populate MonitoringConfig values to GCP_METADATA (#1511) * Populate MonitoringConfig values to GCP_METADATA (#1498) * Populate MonitoringConfig values to GCP_METADATA * Add quotes to fix build lint error * Add quotes to fix build lint error * Resolve minor problem and code optimization * Add double-quotes for lint * Update lint changes * Update the logic to identify empty monitoring config * Update the logic to identify empty monitoring config * Remove unnecessary empty line * Fix the issue for null value of monitoringConfig (#1525) * Fix the issue for null value of monitoringConfig * Use fleet project ID for monitoringConfig * Organize kpt files even in offline mode (#1532) * Bump revision 1.18.5-asm.2 (#1536) * Detect old default ingress gateway earlier in installation flow (#1545) * [1.18] bump revision (#1548) * Bump revision 1.18.7-asm.0 (#1561) * Bump revision 1.18.7-asm.0 * Disable SC2317 since we use trap * Bump revision 1.18.7-asm.5 (#1571) * Bump revision 1.18.7-asm.5 * Update google-cloud packages * Update revision 1.18.7-asm.4 (#1581) * Revision 1.18.7-asm.11 (#1589) * [1.18]Fix cloud-sdk:slim (#1594) * Fix cloud-sdk:slim * remove whitespace --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
sergii-ssh
added a commit
that referenced
this pull request
Apr 24, 2024
* Merge main to staging-1.18 (#1494) * Bump revision 1.18.2-asm.0 (#1481) * Update release script (#1483) * Use top level `istioctl` commands for `create-remote-secret` and `tag` (#1484) Patches for istio/istio#46051 and istio/istio#46257 * Revert Off-GCP metadata population (#1485) * Add --working-dir alias for output directory * Add --working-dir alias for output directory * Update test case to utilize --working-dir alist for output dir * Populate GCP_METADATA by membership monitoring config * Add local variables for lint * Address line-variable error * Revert "Populate GCP_METADATA by membership monitoring config" This reverts commit b3372bd. * Do not support channel selection via CLI args (#1488) Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments. * Update verbose help text for consistency with public docs (#1487) * Support the regionalized membership name parsing (#1490) * Revert "Do not support channel selection via CLI args (#1488)" This reverts commit 8c09b8f. Will re-commit when the channel labeling issue is solved a bit cleaner. * Bump revision 1.18.2-asm.4 (#1493) --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com> * Bump revision 1.18.4-asm.0 (#1505) * Populate MonitoringConfig values to GCP_METADATA (#1511) (#1512) * Populate MonitoringConfig values to GCP_METADATA (#1511) * Populate MonitoringConfig values to GCP_METADATA (#1498) * Populate MonitoringConfig values to GCP_METADATA * Add quotes to fix build lint error * Add quotes to fix build lint error * Resolve minor problem and code optimization * Add double-quotes for lint * Update lint changes * Update the logic to identify empty monitoring config * Update the logic to identify empty monitoring config * Remove unnecessary empty line * Fix the issue for null value of monitoringConfig (#1525) * Fix the issue for null value of monitoringConfig * Use fleet project ID for monitoringConfig * Organize kpt files even in offline mode (#1532) * Bump revision 1.18.5-asm.2 (#1536) * Detect old default ingress gateway earlier in installation flow (#1545) * [1.18] bump revision (#1548) * Bump revision 1.18.7-asm.0 (#1561) * Bump revision 1.18.7-asm.0 * Disable SC2317 since we use trap * Bump revision 1.18.7-asm.5 (#1571) * Bump revision 1.18.7-asm.5 * Update google-cloud packages * Update revision 1.18.7-asm.4 (#1581) * Revision 1.18.7-asm.11 (#1589) * [1.18]Fix cloud-sdk:slim (#1594) * Fix cloud-sdk:slim * remove whitespace * Bump revision 1.18.7-asm.21 --------- Co-authored-by: Wonje Kang <96211823+wonjekang@users.noreply.github.com> Co-authored-by: Clay <ctpence@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing this gives the wrong impression that GKE and ASM channels are independent, which is useless at best and dangerous at worst. We shouldn't be making it easier for customers to run nonstandard environments.