Update install_asm #335
Merged
Update install_asm #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current validate_ca_consistency() function breaks if using a custom ingress gateway selector while the default ingress gateway is disabled. Changing the kubectl filter to label app=istio-ingressgateway resolves the issue.
zerobfd
approved these changes
Dec 18, 2020
zerobfd
pushed a commit
that referenced
this pull request
Dec 18, 2020
* Update installation script to support ASM installation with Hub from non hosting project (#328) * Update installation script to support ASM installation with Hub from non hosting project * Bump RC (#331) * Use 1.8 release branch in release script (#332) * Fix tag (#333) * Don't release install_asm if no changed (#337) * Fix error when installing managed (#339) * Fix validate_ca_consistency with custom ingress selector (#335) The current validate_ca_consistency() function breaks if using a custom ingress gateway selector while the default ingress gateway is disabled. Changing the kubectl filter to label app=istio-ingressgateway resolves the issue. * Handle empty JSON case when initializing managed meshconfig (#334) Co-authored-by: jtrbs <tairan@google.com> Co-authored-by: Frits <frots@users.noreply.github.com>
zerobfd
pushed a commit
to zerobfd/anthos-service-mesh-packages
that referenced
this pull request
Jan 25, 2021
* Update installation script to support ASM installation with Hub from non hosting project (GoogleCloudPlatform#328) * Update installation script to support ASM installation with Hub from non hosting project * Bump RC (GoogleCloudPlatform#331) * Use 1.8 release branch in release script (GoogleCloudPlatform#332) * Fix tag (GoogleCloudPlatform#333) * Don't release install_asm if no changed (GoogleCloudPlatform#337) * Fix error when installing managed (GoogleCloudPlatform#339) * Fix validate_ca_consistency with custom ingress selector (GoogleCloudPlatform#335) The current validate_ca_consistency() function breaks if using a custom ingress gateway selector while the default ingress gateway is disabled. Changing the kubectl filter to label app=istio-ingressgateway resolves the issue. * Handle empty JSON case when initializing managed meshconfig (GoogleCloudPlatform#334) Co-authored-by: jtrbs <tairan@google.com> Co-authored-by: Frits <frots@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom Istio ingress gateway compatbility to validate_ca_consistency() by changing the label selector.