Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not print stacktrace if logging file cannot be found #104

Merged
merged 1 commit into from
Apr 9, 2024
Merged

do not print stacktrace if logging file cannot be found #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions runtime/impl/src/main/java/com/google/apphosting/runtime/Logging.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@

package com.google.apphosting.runtime;

import static java.nio.charset.StandardCharsets.UTF_8;

import javax.annotation.Nullable;
import java.io.BufferedReader;
import java.io.ByteArrayOutputStream;
import java.io.FileInputStream;
Expand All @@ -40,7 +39,8 @@
import java.util.logging.LogRecord;
import java.util.logging.Logger;
import java.util.logging.SimpleFormatter;
import javax.annotation.Nullable;

import static java.nio.charset.StandardCharsets.UTF_8;

/** Configures logging for the GAE Java Runtime. */
public final class Logging {
Expand Down Expand Up @@ -167,7 +167,12 @@ public void logJsonToFile(@Nullable String projectId, Path logPath, boolean clea
try {
printStream = new PrintStream(logPath.toFile());
} catch (FileNotFoundException e) {
logger.log(Level.WARNING, "Unable to create log handler to " + logPath, e);
if (logger.isLoggable(Level.FINE)) {
logger.log(Level.WARNING, "Unable to create log handler to " + logPath, e);
}
else {
logger.log(Level.WARNING, "Unable to create log handler to " + logPath);
}
return;
}

Expand Down
Loading