Skip to content

Commit

Permalink
Revert "Add queue name and target to admin UI"
Browse files Browse the repository at this point in the history
This reverts commit adb3fd1.
  • Loading branch information
tkaitchuck committed Aug 14, 2015
1 parent 633c9fb commit bd9fa1e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 27 deletions.
2 changes: 0 additions & 2 deletions python/src/pipeline/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -2904,7 +2904,6 @@ def _get_internal_status(pipeline_key=None,
outputs: Dictionary of output slot dictionaries.
children: List of child pipeline IDs.
queueName: Queue on which this pipeline is running.
target: Target version/module for the pipeline.
afterSlotKeys: List of Slot Ids after which this pipeline runs.
currentAttempt: Number of the current attempt, starting at 1.
maxAttempts: Maximum number of attempts before aborting.
Expand Down Expand Up @@ -2973,7 +2972,6 @@ def _get_internal_status(pipeline_key=None,
'outputs': params['output_slots'].copy(),
'children': [key.name() for key in pipeline_record.fanned_out],
'queueName': params['queue_name'],
'target': params['target'],
'afterSlotKeys': [str(key) for key in params['after_all']],
'currentAttempt': pipeline_record.current_attempt + 1,
'maxAttempts': pipeline_record.max_attempts,
Expand Down
2 changes: 0 additions & 2 deletions python/src/pipeline/ui/status.css
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ abbr {

/* detail-specific styling */
.status-param,
.target-param,
.retry-param {
padding-left: 1em;
font-size: 0.85em;
Expand Down Expand Up @@ -111,7 +110,6 @@ abbr {
#detail .param-container,
#detail .child-container,
#detail .run-after-container,
#detail .status-target-params,
#detail .status-retry-params {
margin-top: 1em;
}
Expand Down
23 changes: 0 additions & 23 deletions python/src/pipeline/ui/status.js
Original file line number Diff line number Diff line change
Expand Up @@ -326,29 +326,6 @@ function constructStageNode(pipelineId, infoMap, sidebar) {
containerDiv.append(linksDiv);
}

// Target parameters.
if (!sidebar) {
var targetParamsDiv = $('<div class="status-target-params">');
targetParamsDiv.append(
$('<div class="target-params-title">').text('Target parameters'));

var queueNameDiv = $('<div class="target-param">');
$('<span>').text('Queue name: ').appendTo(queueNameDiv);
$('<span>')
.text(infoMap.queueName)
.appendTo(queueNameDiv);
targetParamsDiv.append(queueNameDiv);

var targetDiv = $('<div class="target-param">');
$('<span>').text('Target: ').appendTo(targetDiv);
$('<span>')
.text(infoMap.target || 'Unspecified')
.appendTo(targetDiv);
targetParamsDiv.append(targetDiv);

containerDiv.append(targetParamsDiv);
}

// Retry parameters.
if (!sidebar) {
var retryParamsDiv = $('<div class="status-retry-params">');
Expand Down

1 comment on commit bd9fa1e

@tkaitchuck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alangpierce Reverting this for the moment. It broke some tests that I haven't gotten to the bottom of yet.

Please sign in to comment.