Fixes Issue #60 #61
Merged
Fixes Issue #60 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was tried differently before in commit 443e311. For barrier notifications, this was tried before by getting all barrier records' pipeline keys and doing a batch get, but that method did not account for situations in which barrier checks were fired but no pipes were ready yet. My method will potentially result in more RPC requests, but only pipes that are ready to be executed will be fetched. For retries: we already have the `pipeline_record` fetched, just pass in the target parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was tried differently before in commit 443e311.
For barrier notifications, this was tried before by getting all barrier records' pipeline keys and doing a batch get, but that method did not account for situations in which barrier checks were fired but no pipes were ready yet. My method will potentially result in more RPC requests, but only pipes that are ready to be executed will be fetched.
For retries: we already have the
pipeline_recordfetched, just pass in the target parameter