Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TEST_MODE true for dev envs #78

Closed

Conversation

paulbynd
Copy link

@paulbynd paulbynd commented Jun 9, 2017

Per @rtshadow's comment on #72, enable TEST_MODE when in dev_appserver to avoid an otherwise confusing and fatal error later.

Per @rtshadow's comment on GoogleCloudPlatform#72, enable TEST_MODE when in dev_appserver to avoid an otherwise confusing and fatal error later.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@paulbynd
Copy link
Author

paulbynd commented Jun 9, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

cjfuller pushed a commit to Khan/appengine-pipelines that referenced this pull request Jun 23, 2017
Summary:

After upgrading the appengine SDK to 1.9.54, several of our pipeline
tests broke.  This is a known issue with an outstanding pull request:
GoogleCloudPlatform#78

However, the fix from the pull request, which I applied in
https://phabricator.khanacademy.org/rGAPPI1c757b3d21eb9fe5bbf4a9c503a6292a2de6a15a
doesn't appear to be the right fix for us, as setting `_TEST_MODE` has
other side effects that we don't want.

Instead, we want to *route* as if we're in _TEST_MODE-- i.e. set
_TEST_MODE based on the server software in that function only-- but not
set _TEST_MODE everywhere.

Test plan:
- substate into webapp
- `make check`

Auditors: csilvers
@blech
Copy link

blech commented Aug 14, 2017

I'll admit that this is a hack rather than a well tested solution, and I suspect @cjfuller's fix, or instead a better resolution of the underlying #71 issue, would be better. Thanks for commenting, and perhaps I'll try running with an explicit app and version name and see if that avoids the issue.

@paulbynd paulbynd closed this Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants