Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitProcessOutputListener needs to be provided by the AppEngineDevServer implementation #331

Open
patflynn opened this issue Feb 15, 2017 · 5 comments

Comments

@patflynn
Copy link
Contributor

related to #330

currently CloudSdk#637 hardcodes the value that triggers server startup complete event.

@patflynn patflynn added this to the next release milestone Feb 15, 2017
@patflynn
Copy link
Contributor Author

@loosebazooka we need this fix in for the IDE integrations to work with Ludo's PR.

@loosebazooka
Copy link
Contributor

Is this a stdout vs stderr thing? The string we are looking for is correct.

@chanseokoh
Copy link
Contributor

@loosebazooka Oh, so devappserver1 and 2 both use the same log message when starting up?

".*(Dev App Server is now running|INFO:oejs\\.Server:main: Started).*",

@loosebazooka
Copy link
Contributor

dev appserver 1 is the first part and dev appserver 2 is the second.

@chanseokoh
Copy link
Contributor

Got it. I thought this issue is talking about refactoring the code so that the expected log messages are provided by server implementations rather than hard-coded in CloudSdk, but we may be okay as long as it's working.

@elharo elharo removed this from the next release milestone Dec 2, 2020
@loosebazooka loosebazooka removed their assignment Dec 21, 2022
JoeWang1127 pushed a commit that referenced this issue Nov 29, 2023
Feedback from @shiraji . The footnote is not shown correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants