-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loadgenerator race condition #1029
Merged
bourgeoisor
merged 3 commits into
GoogleCloudPlatform:main
from
oginskis:fix-loadgenerator-race-condition
Oct 18, 2022
Merged
Fix loadgenerator race condition #1029
bourgeoisor
merged 3 commits into
GoogleCloudPlatform:main
from
oginskis:fix-loadgenerator-race-condition
Oct 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealSpaceShip
force-pushed
the
fix-loadgenerator-race-condition
branch
from
October 17, 2022 11:57
546d6b7
to
748ee69
Compare
Lint is failing:
|
TheRealSpaceShip
force-pushed
the
fix-loadgenerator-race-condition
branch
2 times, most recently
from
October 18, 2022 08:36
9c1682b
to
8ffd87c
Compare
The load generator seems to be more in-line with failure expectations:
Vs. what's currently in the main branch:
|
bourgeoisor
requested changes
Oct 18, 2022
Handle to avoid calls of authenticated endpoints when logout has already called
TheRealSpaceShip
force-pushed
the
fix-loadgenerator-race-condition
branch
from
October 18, 2022 19:50
8ffd87c
to
15c6e55
Compare
After latest commit:
Looks great! |
bourgeoisor
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle to avoid calls of authenticated endpoints when logout has already been called
Background
Almost 50% of authenticated requests are failing with error code 401 because of the request-logout race.
Change Summary
Fixed logic on how signup+login and logout works. Also made some small improvements.