Fix typo in frontend container name
#1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, fixing the container name from
fronttofrontend.I don't see any breaking change with that. I found this issue when doing Kustomize with the Kubernetes manifests, when patching based on the container name, by consistency, I was taking the name of the service as the container name but found out the hard way that the container name of the
frontenddeployment wasfront.So proposing this fix. Otherwise in my Kustomize I could just patch the
frontcontainer name, but thought it would be ideal to have this fix for consistency (and maybe avoiding any friction for someone who will try this). Let me know what do you think.