-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GKE Autopilot Tutorial: Resource requirement update for userservice #1054
GKE Autopilot Tutorial: Resource requirement update for userservice #1054
Conversation
Hi @oginskis! Two quick notes:
Feel free to make those two changes and I'll re-verify this PR |
cpu: 200m | ||
memory: 64Mi | ||
cpu: 300m | ||
memory: 128Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bourgeoisor first off, thank you for thoroughly testing this pull-request.
Question: Have I interpreted your suggestions correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thank you very much, Nim!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Autopilot sets limits to request values (reference: https://cloud.google.com/kubernetes-engine/docs/concepts/autopilot-resource-requests#resource-limits) therefore the userservice gets only up to 200 milicores of CPU at maximum on the Autopilot. The userservice generates JWT tokens which are CPU-consuming and currently it takes several seconds for a user to log in.
I propose to set the CPU requests to 500m to improve the UX.
@bourgeoisor