Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microservices liveness probes with help of Prometheus #1173

Merged
merged 6 commits into from
Feb 14, 2023
Merged

Microservices liveness probes with help of Prometheus #1173

merged 6 commits into from
Feb 14, 2023

Conversation

TheRealSpaceShip
Copy link
Contributor

This PR contains manifest files for the setup of the microservices liveness probes with Prometheus (OSS and GMP)

  • Configure the liveness probes with help of Blackbox exporter probes
  • Configure Alert rules
  • Configure Alertmanager to send notifications via Slack channel

@TheRealSpaceShip TheRealSpaceShip requested a review from a team as a code owner December 20, 2022 15:26
@bourgeoisor
Copy link
Member

@TheRealSpaceShip is this PR ready to be reviewed?

@TheRealSpaceShip
Copy link
Contributor Author

Yes, please, review it.

@bourgeoisor bourgeoisor self-assigned this Jan 17, 2023
Shabirmean
Shabirmean suggested changes Feb 3, 2023
View reviewed changes
Copy link
Member

@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these improvements @TheRealSpaceShip . Very much appreciate the effort here. Please TAL at the comments. Also please update your branch with the latest changes from the main branch!

extras/prometheus/README.md Outdated Show resolved Hide resolved
extras/prometheus/README.md Outdated Show resolved Hide resolved
extras/prometheus/gmp/README.md Outdated Show resolved Hide resolved
extras/prometheus/gmp/README.md Outdated Show resolved Hide resolved
extras/prometheus/gmp/README.md Show resolved Hide resolved
extras/prometheus/oss/README.md Outdated Show resolved Hide resolved
extras/prometheus/oss/README.md Outdated Show resolved Hide resolved
extras/prometheus/oss/README.md Outdated Show resolved Hide resolved
extras/prometheus/oss/alertmanagerconfig.yaml Outdated Show resolved Hide resolved
extras/prometheus/oss/rules.yaml Outdated Show resolved Hide resolved
Shabirmean
Shabirmean reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adopting the changes. 🚀

PR wise it looks good to me. I'll let @bourgeoisor make the final review on approving and merging this!

@bourgeoisor
Copy link
Member

bourgeoisor commented Feb 13, 2023 •
edited

@TheRealSpaceShip would it be possible in the READMEs of the gmp/ and oss/ directories to have very quick instructions on how to run this? Not a full tutorial, just a quick few bullet points like:

  • Install Bank of Anthos on your GKE cluster
  • Run helm install foobar
  • Run kubectl apply foobar

etc etc.

Once that's there I think this is good to go!

@TheRealSpaceShip
Copy link
Contributor Author

@bourgeoisor done. I have added short instructions to both READMEs.

@bourgeoisor bourgeoisor merged commit 7c5b0dc into GoogleCloudPlatform:main Feb 14, 2023
big-appled pushed a commit to big-appled/bank-of-anthos that referenced this pull request Jun 9, 2023
@TheRealSpaceShip @Shabirmean @big-appled
Microservices liveness probes with help of Prometheus (GoogleCloudPla…
8cf310d 
…tform#1173)

* Prometheus related config files

* License added

* Apply suggestions from code review

Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>

* Apply review comments

* Update READMEs after review

* Update READMEs for gms and oss

---------

Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@Shabirmean Shabirmean Awaiting requested review from Shabirmean

Assignees

@bourgeoisor bourgeoisor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheRealSpaceShip @bourgeoisor @Shabirmean