Add tests for userservice and supporting refactor #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
commented
Apr 15, 2020
daniel-sanche
suggested changes
Apr 16, 2020
djmailhot
reviewed
Apr 16, 2020
daniel-sanche
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
One more small request: Can you mention the python unit tests in the workflow README?
Other than that, LGTM
add unit test to workfloe clean deps, add venv to sh script address comments descriptive unit test function names
bharathkkb
force-pushed
the
add-user-svc-tests
branch
from
f1c23c1
to
a65f8eb
Compare
murog
reviewed
Apr 22, 2020
murog
reviewed
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
part of #51
-- enables users to run userservice locally using flask dev server
python3 userservice.py-- easier to create test instances