Updated ledgermonolith README and modified init script to handle multi-instance installations #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-instance installations
|
🚀 PR staged at http://35.224.10.67 |
|
Would also be good to get the |
|
🚀 PR staged at http://35.224.10.67 |
big-appled
pushed a commit
to big-appled/bank-of-anthos
that referenced
this pull request
Jun 9, 2023
…i-instance installations (GoogleCloudPlatform#1293) Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The README was not up to date and did not work. You could only use the script to deploy both the service and database to the same instance. We have use cases where we would like to deploy the service and database on separate instances.
Change Summary
Updated the README and makefile to work properly.
Updated the install-script to allow for installing the service and database on separate instances
Testing Procedure
Tested using the updated README and Migrating a monolith VM