Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing environment variable #1338

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Added missing environment variable #1338

merged 1 commit into from
Mar 7, 2023

Conversation

arueth
Copy link
Collaborator

@arueth arueth commented Mar 6, 2023

Background

The initdb/1_create_transactions.sh script was not running because the POSTGRES_PASSWORD was missing from the --preserve-env list

Change Summary

Add missing environment variable to the --preserve-env list

Testing Procedure

Tested locally with my repository

@arueth arueth requested a review from a team as a code owner March 6, 2023 22:50
@arueth
Copy link
Collaborator Author

arueth commented Mar 6, 2023

It looks like the POSTGRES_PASSWORDwas added in 0629f15 which had not yet been propigated to the bank-of-anthos-ci bucket.

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

🚀 PR staged at http://34.170.129.111

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@bourgeoisor bourgeoisor merged commit 77d846e into main Mar 7, 2023
@bourgeoisor bourgeoisor deleted the arueth-fix branch March 7, 2023 16:17
big-appled pushed a commit to big-appled/bank-of-anthos that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants