Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to sources on README #1416

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

ksprashu
Copy link
Contributor

@ksprashu ksprashu commented Apr 5, 2023

Fixes #1415

Background

Links to the source folders on the README was broken. This PR fixes the broken references.

Change Summary

The URLs that were broken have been updated to the correct source folders.

Additional Notes

N/A

Testing Procedure

Navigated to every service listed and tested that all links were working.

Related PRs or Issues

N/A

@ksprashu ksprashu requested review from a team and yoshi-approver as code owners April 5, 2023 08:49
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@bourgeoisor bourgeoisor merged commit 67d3f09 into GoogleCloudPlatform:main Apr 5, 2023
3 of 4 checks passed
big-appled pushed a commit to big-appled/bank-of-anthos that referenced this pull request Jun 9, 2023
* Fix broken references to sources in Service Architecture

* fix reference to userservice sources

* Align (beautify) column separators on markdown table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to sources of services under service architecture in README are not up-to-date and are broken.
2 participants