Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize docs and update releasing script & README #1418

Merged
merged 13 commits into from
Apr 5, 2023

Conversation

bourgeoisor
Copy link
Member

@bourgeoisor bourgeoisor commented Apr 5, 2023

This PR:

  • Moves all screenshots from docs/ to docs/img/ to clean up
  • Moves releasing README and script from release/ to docs/
    • This is partly due to the understandable misinterpretation that the release/ directory contains the "latest release" of Bank of Anthos (which has never been true), but also to consolidate all docs together
  • Updates releasing README and script to reflect CI/CD pipeline refactor ([BREAKING CHANGES] Refactor of CI/CD, kustomize & skaffold #1221)
  • Lowers slightly the CPU of userservice to neatly fit in a 3-node default cluster

Staging:

@bourgeoisor bourgeoisor requested review from a team and yoshi-approver as code owners April 5, 2023 17:43
@bourgeoisor bourgeoisor changed the base branch from main to issue-move-meta-file-github April 5, 2023 17:47
# set default repo
REPO_PREFIX="${REPO_PREFIX:-gcr.io/bank-of-anthos-ci}"
# set env
REPO_PREFIX="${REPO_PREFIX:-us-central1-docker.pkg.dev/bank-of-anthos-ci/bank-of-anthos}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY for moving to Artifact Registry!
:( for Artifact Registry's long URLs.

Base automatically changed from issue-move-meta-file-github to main April 5, 2023 18:06
@NimJay
Copy link
Collaborator

NimJay commented Apr 5, 2023

I have not tested docs/releasing/make-release.sh, but I don't think it's necessary to test (to approve this PR).
If there are any bugs in docs/releasing/make-release.sh, we will find them during the next release. :)

@bourgeoisor bourgeoisor merged commit 3f66afe into main Apr 5, 2023
@bourgeoisor bourgeoisor deleted the issue-fix-releasing-readme branch April 5, 2023 18:11
big-appled pushed a commit to big-appled/bank-of-anthos that referenced this pull request Jun 9, 2023
…form#1418)

* Reorganize docs and images together

* Reduce userservice CPU to fit within 3-node default cluster

* Move releasing script in the docs

* Modify releasing script for new skaffold modules

* Move meta files to .github directory

* Move root README to .github directory

* Fix relative links in README

* Fix default repo in make-release script

* Update releasing README

* Add screenshot of Cloud Deploy

* Move root README to docs directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants