-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used a ThreadPoolExecutor to make concurrent API calls #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arueth
force-pushed
the
arueth-issue-353
branch
2 times, most recently
from
May 5, 2023 16:43
d0904d6
to
1cac436
Compare
This is what I get on the current latest release (https://bank-of-anthos.xyz): So it seems that's this PR's changes |
Using the threads must not play nice with the open telemetry plugin. |
I'm doing some refactoring to get the tracing working, expect an update shortly. |
bourgeoisor
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
Background
Currently the fronted makes serial calls to the backend services, with this change it will make concurrent calls and therefore return the page quicker.
Change Summary
Change from serial to concurrent calls to the backend services.
Testing Procedure
Deploy the application in an environment and check the loading times for the home page.
My development environment is here: http://34.168.42.167/
Related PRs or Issues
None