Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default sync_branch var to point to branch #1507

Merged
merged 2 commits into from
May 12, 2023

Conversation

LisaFC
Copy link
Contributor

@LisaFC LisaFC commented May 12, 2023

Background

Sync branch was actually pointing to a tag name rather than a branch name, which meant it wasn't picking up all the changes in the release branch (including a changed directory name).

Change Summary

Changed the default value for this variable

Sync branch was actually pointing to a tag name rather than a branch name, which meant it wasn't picking up all the changes in the release branch.
@LisaFC LisaFC requested review from a team and yoshi-approver as code owners May 12, 2023 17:22
Fixed directory name for 0.6.0
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bourgeoisor bourgeoisor changed the title Update sync_branch var Update default sync_branch var to point to branch May 12, 2023
@bourgeoisor bourgeoisor merged commit c8ec386 into GoogleCloudPlatform:main May 12, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants