Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Cloud SQL Proxy v2 #1708

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Updated to Cloud SQL Proxy v2 #1708

merged 1 commit into from
Jan 19, 2024

Conversation

arueth
Copy link
Collaborator

@arueth arueth commented Aug 8, 2023

Background/Change Summary

  • Updated to Cloud SQL Proxy v2 in preparation for some upcoming fleet workload identity work

Testing Procedure

Tested in my project using https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/main/docs/ci-cd-pipeline.md

@arueth arueth requested review from yoshi-approver and a team as code owners August 8, 2023 17:03
@arueth arueth enabled auto-merge (squash) August 8, 2023 21:38
@arueth arueth force-pushed the rueth-dev branch 4 times, most recently from 170ab58 to 6ccd12d Compare August 10, 2023 19:06
@bourgeoisor bourgeoisor self-assigned this Aug 11, 2023
@bourgeoisor
Copy link
Member

@arueth currently (or at least last I tried), Bank of Anthos could juuuust fit in a 3-node default config GKE Standard cluster. This PR bumps a lot of requests upwards (sometimes 2x or 3x). What do you think is the new requirement if deploying in a GKE Standard cluster with these changes?

@arueth
Copy link
Collaborator Author

arueth commented Aug 14, 2023

So this is the new configuration running in my environment
Screenshot 2023-08-14 9 16 02 AM

I don't have development deployed.

@arueth
Copy link
Collaborator Author

arueth commented Aug 14, 2023

We could create a "minimal" skaffold profile if we wanted to get really lean.

@bourgeoisor
Copy link
Member

The reason I mention this is because there's a lot of learning content that leverages Bank of Anthos' default configs which still uses GKE Standard with a limited # of nodes (e.g. 3 or 4). If we bump the default base requests that may break that learning content.

For example, this tutorial deploys default Bank of Anthos on a 4-node cluster: https://cloud.google.com/migrate/containers/docs/migrating-monolith-vm-overview-setup#deploy

You can see a more complete list here: go/boa-usage (internal)

What do you think?

@arueth
Copy link
Collaborator Author

arueth commented Aug 18, 2023

Are the skaffold changes and kubernetes-manifests folders kept synchronized? I believe the vast majority of tutorials outside of the docs in the repo use the kubernetes-manifests folder, is that correct?

@bourgeoisor
Copy link
Member

Correct! 90+% of tutorials don't use kustomize / skaffold, they just kubectl apply -f the kubernetes-manifests/ directory.

The sync is made at release time (new release of Bank of Anthos) where we skaffold render

https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/main/docs/releasing/make-release.sh#L58-L72

@arueth
Copy link
Collaborator Author

arueth commented Aug 22, 2023

Would you prefer I move these changes out to a separate autopilot profile or only apply them to the staging/production profiles? It looks like the make-release.sh uses the development profile.

@bourgeoisor
Copy link
Member

Yes, kubernetes-manifests/ is essentially the barebone development profile (no Cloud SQL, low resources needed, etc)

How about we make the higher-resources-requests changes on the staging/production profiles like you're suggesting? That way the development profile (and by extension, the generated "barebones" k8s manifests) stay minimal

@arueth
Copy link
Collaborator Author

arueth commented Jan 12, 2024

Since the Autopilot minimums are going to change, I'm changing this to only include the Cloud SQL Proxy v2 changes.

@arueth arueth force-pushed the rueth-dev branch 9 times, most recently from 6aea7d9 to 20c35ea Compare January 17, 2024 18:41
@arueth arueth force-pushed the rueth-dev branch 4 times, most recently from 6f741b5 to 5b73b9f Compare January 18, 2024 22:39
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arueth arueth merged commit 549c55f into main Jan 19, 2024
8 checks passed
@arueth arueth deleted the rueth-dev branch January 19, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants