Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preview skaffold version from Cloud Build / Deploy step #1802

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

bourgeoisor
Copy link
Member

This PR removes the experimental Skaffold version flag from the Cloud Deploy release creation. This flag used to be necessary when it was added since we were relying on Skaffold changes that were not included in the default Cloud Deploy release, but nowadays Cloud Deploy uses Skaffold 2.6 by default which is more than sufficient for our needs.

Copy link

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bourgeoisor bourgeoisor merged commit 889f746 into main Sep 20, 2023
7 checks passed
@bourgeoisor bourgeoisor deleted the issue-remove-preview-skaffold-cloud-build branch September 20, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants