Disabled spring.cloud.gcp.trace to stop ADC lookup #2044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1998
Background
Even with
spring.sleuth.enabled
set tofalse
, zipkin2 tried to lookup the ADC credentials. This causes the application to crash on some environments.Change Summary
Added
spring.cloud.gcp.trace.enabled
to be set via theENABLE_TRACING
environment variable as well to fully disable the trace functionality in the apps.Testing Procedure
Tested on my personal machine using Docker Desktop.