Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storage utm #54

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Add storage utm #54

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0a72d0
add new Storage UTMMedium
Aric1088 Aug 5, 2020
e7359ab
change enum
Aric1088 Aug 5, 2020
210c23b
Remove replace
Aric1088 Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/notifiers/notifiers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,8 @@ type UTMMedium string
const (
// EmailMedium is for Build log URLs that are sent via email.
EmailMedium UTMMedium = "email"
// StorageMedium is for Build log URLS that are sent to a storage medium (i.e. BigQuery).
StorageMedium = "storage"
// ChatMedium is for Build log URLs that are sent over chat applications.
ChatMedium = "chat"
// HTTPMedium is for Build log URLs that are sent over HTTP(S) communication (that does not belong to one of the other mediums).
Expand All @@ -473,7 +475,7 @@ func AddUTMParams(logURL string, medium UTMMedium) (string, error) {

var m string
switch medium {
case EmailMedium, ChatMedium, HTTPMedium, OtherMedium:
case EmailMedium, StorageMedium, ChatMedium, HTTPMedium, OtherMedium:
m = string(medium)
default:
return "", fmt.Errorf("unknown UTM medium: %q", medium)
Expand Down