Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Yarn 2 out-of-the-box compatibility #746

Closed
sylvainar opened this issue Feb 5, 2021 · 7 comments
Closed

[FR] Yarn 2 out-of-the-box compatibility #746

sylvainar opened this issue Feb 5, 2021 · 7 comments
Labels
invalid not reproducible; works as intended; off-topic questions; etc. off-topic off-topic questions; see the template for full explanation

Comments

@sylvainar
Copy link

Notice

To request a feature in the hosted Google Cloud Build service, please contact your Google Cloud Support representative or suggest your feature using Google's public issue tracker.

This GitHub issue tracker is intended for feature requests in the officially supported builder images only. This issue tracker is not the right place to request features like triggers or notifications.

If you're not sure where to suggest your feature, use Google's public issue tracker.

Detailed Feature Information

Which builder is relevant to this request?
Node / Yarn

Is your feature request related to a problem? Please describe.
Yarn 2 is not currently properly supported by cloud-build:

  • Caching is not efficient (every package is fetched at every build)
    Screenshot_20210205_103923
  • There are a lot of warnings, like this one:
2021-02-05 10:32:13.866 CET
Step #6 - "builder": ➤ YN0050: The --frozen-lockfile option is deprecated; use --immutable and/or --immutable-cache instead
  • Install seems to occur twice, without cache, which makes almost all my builds ending up in timeouts
    Screenshot_20210205_104107

Describe the solution you'd like
Out-of-the-box yarn 2 integration.

Describe alternatives you've considered
currently working on a workaround, will add insights with my progress

Additional context
...

@bendory
Copy link
Member

bendory commented Feb 8, 2021

So IIUC, you are asking that a yarn2-compatible builder be added @sylvainar?

@sylvainar
Copy link
Author

That would be great indeed, however I'm mostly using Cloud Build to deploy on GAE and I'm not totally sure of the compatibility GAE/yarn2 yet, I can't find any documentation on the web. Maybe that's a bit too soon, anyway I ended up roll backing to yarn1 on my side.

@bendory
Copy link
Member

bendory commented Feb 10, 2021

I'm not a yarn user, but it looks to me like it's the same CLI with different options and default settings. Am I misunderstanding?

@sylvainar
Copy link
Author

They do indeed, however it seems that we need extra parameters or configuration linked to the issues I posted in the first post.

@bendory
Copy link
Member

bendory commented Feb 11, 2021

They do indeed, however it seems that we need extra parameters or configuration linked to the issues I posted in the first post.

Perhaps I'm misunderstanding something (again, I'm not a yarn user) -- is there a reason that you can't pass those extra parameters to your build step as args? Is there a reason you can't submit the required configuration as part of your build?

I'm having trouble understanding what the issue is that you are reporting regarding the existing yarn build step?

@sylvainar
Copy link
Author

I'm a beginner in Cloud Build, in fact I only learned recently that having a gcp-build in your package.json while deploying to GAE triggers a Cloud Build job. What I miss is, why does it work so well with yarn1 when it struggles that much with yarn2 ?

I can probably add some parameters to the command but it kinda break the "flawless integration" between GAE and Cloud Build that you have out-of-the-box with yarn1.

@bendory
Copy link
Member

bendory commented Feb 12, 2021

I'm closing this as WAI; there is no reported issue here with our existing yarn builder.

Please report App Engine issues using the App Engine Issue Tracker or please escalate your individual issue to your Google Cloud Support representative.

@bendory bendory closed this as completed Feb 12, 2021
@GoogleCloudPlatform GoogleCloudPlatform locked as off-topic and limited conversation to collaborators Feb 12, 2021
@bendory bendory added invalid not reproducible; works as intended; off-topic questions; etc. off-topic off-topic questions; see the template for full explanation and removed enhancement feature request help wanted labels Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid not reproducible; works as intended; off-topic questions; etc. off-topic off-topic questions; see the template for full explanation
Projects
None yet
Development

No branches or pull requests

2 participants