Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the way we set K8s context for run configurations #2528

Closed
ivanporty opened this issue May 1, 2019 · 4 comments
Closed

Unify the way we set K8s context for run configurations #2528

ivanporty opened this issue May 1, 2019 · 4 comments
Assignees
Labels
area/kubernetes All Kubernetes and container tools features
Milestone

Comments

@ivanporty
Copy link
Contributor

Currently one needs to manually query KubectlApi in background to obtain the context name and set in on the configuration in order it to become valid.
Options:

  1. Treat empty (unset) context as an active one. In UI, populate empty combobox with an active context when run configuration editor opens for the first time. Do not throw exception when run configuration doesn't have context set, just proceed with deployment to whatever active one is.

  2. Move context setting logic to SkaffoldRunConfigurationManager.addSkaffoldRunConfiguration methods. Do not require setting the context (make it optional), and when not specifyed, query KubectlApi and set the context after it's available. Cons: the run configuration remains invalid (although it might be valid if active context is available) until kubectl job returns.

@ivanporty ivanporty added the area/kubernetes All Kubernetes and container tools features label May 1, 2019
@ivanporty ivanporty added this to the 19.5.1 milestone May 1, 2019
@etanshaul
Copy link
Contributor

I’m not totally sure I understand option 2, but I definitely think 1 is something we should do.

@etanshaul
Copy link
Contributor

Also it seems like this issue can be unified with #2529?

@matthewmichihara
Copy link
Member

Yup I think both of these issues spawned from the same convo.

@etanshaul
Copy link
Contributor

assigned to @matthewmichihara since I think you are working on this based on offline conversations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes All Kubernetes and container tools features
Projects
None yet
Development

No branches or pull requests

3 participants