Adds Maven Wrapper for Java samples - guestbook and hello world, updates them to use the updated Skaffold Jib schema. #154
Conversation
| mingw=false | ||
| case "`uname`" in | ||
| CYGWIN*) cygwin=true ;; | ||
| MINGW*) mingw=true;; |
There was a problem hiding this comment.
and what happens on Windows if I don't have cygwin installed?
There was a problem hiding this comment.
That one I am not sure.. the wrapper is supposedly tested agains major platforms. In case of issues we could also make fixes and upstream to the wrapper repo?
| fi | ||
|
|
||
| # For Cygwin, ensure paths are in UNIX format before anything is touched | ||
| if $cygwin ; then |
There was a problem hiding this comment.
Should be working for most cases since this is pretty widespread tool, but if we have a problem, we can post a fix to the repo and request a new release.
|
Should be good to go. |
|
@simonz130 this should be good to go, but CI fails - I think some problem with Python samples after the latest upgrades? |
|
I'm going to merge this now since the log shows errors in Go template that is not affected by this changelist in any way. Looks like flackiness that we need to address separately in #162 |
Fixes #152
Fixes #110
Adds Maven Wrapper to Java samples to make them zero-friction even for machines where Maven is not in the PATH (in many cases for developers working with IntelliJ where everything is pre-bundled).
Updates schema to vbeta15, to use the latest Jib updates and make sure the multi-module Guestbook application is configured properly to work with both Maven and Maven Wrapper, following the Jib team recommendation.