Add manual end-to-end test fixture #55
Conversation
cristiancavalli
force-pushed
the
dev-feature/e2e-server-fixtures
branch
from
d8aa724
to
075e132
Compare
cristiancavalli
force-pushed
the
dev-feature/e2e-server-fixtures
branch
2 times, most recently
from
155d028
to
d764bf7
Compare
|
Changes Unknown when pulling d764bf7 on cristiancavalli:dev-feature/e2e-server-fixtures into * on GoogleCloudPlatform:master*. |
|
Changes Unknown when pulling d764bf7 on cristiancavalli:dev-feature/e2e-server-fixtures into * on GoogleCloudPlatform:master*. |
|
Changes Unknown when pulling d764bf7 on cristiancavalli:dev-feature/e2e-server-fixtures into * on GoogleCloudPlatform:master*. |
|
Changes Unknown when pulling d764bf7 on cristiancavalli:dev-feature/e2e-server-fixtures into * on GoogleCloudPlatform:master*. |
Add a e2e test using the manual interface. Add delete/get API interfaces as extensions of the auth client for presence checking of transmitted errors. Set e2e fixture to run after integration and unit suite. Notes: The e2e fixture is running extraordinarily slowly but that is because of the 120000ms timeouts which must take place between remote deletes/creates and reads.
cristiancavalli
force-pushed
the
dev-feature/e2e-server-fixtures
branch
from
d764bf7
to
82cf43d
Compare
|
@GoogleCloudPlatform/node-team PTAL |
| t.assert(!isEmpty(groups), 'Groups should not be empty'); | ||
| t.end(); | ||
| }); | ||
| }, 1200); |
There was a problem hiding this comment.
Move the constant to a var at the top of the file for easy timeout tweaking in the future.
There was a problem hiding this comment.
Is 1.2seconds long enough for the errors service to be able to reflect updates back to us?
There was a problem hiding this comment.
@ofrobots I can't find the docs indicating the SLA, 1.2 passes my integration tests consistently
There was a problem hiding this comment.
I think you should use at least 20 seconds as the delay to make sure we don't have flaky test failures.
Also, I think this test might need to be updated to be a mocha test now.
There was a problem hiding this comment.
Example of a system-test from google-cloud-logging: https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/packages/logging-winston/system-test/logging-winston.js#L30
|
This PR has been closed since its contents have been incorporated into the google-cloud-node/error-reporting repository via PR #2264. |
Add a e2e test using the manual interface. Add delete/get API
interfaces as extensions of the auth client for presence checking
of transmitted errors. Set e2e fixture to run after integration
and unit suite.
Notes:
The e2e fixture is running extraordinarily slowly but that is
because of the 120000ms timeouts which must take place between
remote deletes/creates and reads.